Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[master] Unified oneDNN pooling implementation calls#20776

Closed
piotrwolinski-intel wants to merge 5 commits intoapache:masterfrom
piotrwolinski-intel:piotrwolinski/unify-onednn-pooling-implementation-calls
Closed

[master] Unified oneDNN pooling implementation calls#20776
piotrwolinski-intel wants to merge 5 commits intoapache:masterfrom
piotrwolinski-intel:piotrwolinski/unify-onednn-pooling-implementation-calls

Conversation

@piotrwolinski-intel
Copy link
Copy Markdown
Contributor

@piotrwolinski-intel piotrwolinski-intel commented Dec 13, 2021

Unified calling of oneDNN implementations, so now all pooling operators are using same style as other operators using oneDNN

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Dec 13, 2021

Hey @piotrwolinski-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, website, unix-gpu, sanity, centos-gpu, windows-cpu, unix-cpu, edge, miscellaneous, centos-cpu, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 13, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 13, 2021
bartekkuncer
bartekkuncer reviewed Dec 14, 2021
View reviewed changes
Comment thread src/operator/nn/dnnl/dnnl_pooling-inl.h
Comment thread src/operator/nn/dnnl/dnnl_pooling-inl.h
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 28, 2021
@piotrwolinski-intel
Copy link
Copy Markdown
Contributor Author

piotrwolinski-intel commented Dec 28, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Dec 28, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 28, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jan 11, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 17, 2022
@piotrwolinski-intel piotrwolinski-intel force-pushed the piotrwolinski/unify-onednn-pooling-implementation-calls branch from 24081a0 to b3520df Compare February 17, 2022 11:48
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge labels Feb 17, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 17, 2022
@piotrwolinski-intel
Copy link
Copy Markdown
Contributor Author

piotrwolinski-intel commented Feb 24, 2022

@mxnet-bot run ci [unix-cpu, windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Feb 24, 2022

Jenkins CI successfully triggered : [windows-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 24, 2022
@piotrwolinski-intel
Copy link
Copy Markdown
Contributor Author

piotrwolinski-intel commented Feb 28, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Feb 28, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 28, 2022
@bgawrych
Copy link
Copy Markdown
Contributor

bgawrych commented Mar 8, 2022

@piotrwolinski-intel Can you rebase this change?

@piotrwolinski-intel
Copy link
Copy Markdown
Contributor Author

piotrwolinski-intel commented Mar 17, 2022

Changes in this PR got obsolete due to the #20825 that also introduced them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha

@leezu leezu Awaiting requested review from leezu

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham

@marcoabreu marcoabreu Awaiting requested review from marcoabreu

@nswamy nswamy Awaiting requested review from nswamy

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin

2 more reviewers

@bgawrych bgawrych bgawrych approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-work-in-progress PR is still work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@piotrwolinski-intel @mxnet-bot @bgawrych @bartekkuncer @mseth10